adam/open-swe
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/open-swe.git synced 2026-10-07 16:19:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: restore login page render and clear CI lint/format

Browse source 
The plan-review port removed the authRedirectUrl import from login.tsx
but left its call site, crashing the login page at runtime (blank page,
no 'Sign in to open-swe'). Pass the relative path straight to loginUrl,
matching the plan route and the backend relative-redirect handling.

Also drop an unused os import in the guard test and reformat
workflow_push_guard.py to satisfy ruff.
This commit is contained in:
Adam Moussa 2026-07-09 14:25:05 -04:00
parent a09b1c3bb6
commit 2a5c69211d
No known key found for this signature in database
3 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
agent/middleware/workflow_push_guard.py
View file

@ -653,9 +653,7 @@ def _workflow_change_for_push(backend: Any, parsed: ParsedGitPush) -> WorkflowPu
fixed_command = _git_command(root, " ".join(shlex.quote(arg) for arg in fixed_args)) fixed_command = _git_command(root, " ".join(shlex.quote(arg) for arg in fixed_args))
# Fetch diff preview for the workflow approval card. # Fetch diff preview for the workflow approval card.
diff_range = ( diff_range = f"{shlex.quote(base_ref)}...{shlex.quote(head)}" if base_ref else shlex.quote(head)
f"{shlex.quote(base_ref)}...{shlex.quote(head)}" if base_ref else shlex.quote(head)
)
diff = _run_git(backend, root, f"diff --binary --full-index {diff_range} -- .github/workflows") diff = _run_git(backend, root, f"diff --binary --full-index {diff_range} -- .github/workflows")
numstat = None numstat = None
diff_preview = "" diff_preview = ""
@ -669,7 +667,8 @@ def _workflow_change_for_push(backend: Any, parsed: ParsedGitPush) -> WorkflowPu
diff_stats_val = _diff_stats(files, numstat.output) diff_stats_val = _diff_stats(files, numstat.output)
elif base_ref and not diff.ok: elif base_ref and not diff.ok:
diff_only_head = _run_git( diff_only_head = _run_git(
backend, root, backend,
root,
f"diff --binary --full-index --root {shlex.quote(head)} -- .github/workflows", f"diff --binary --full-index --root {shlex.quote(head)} -- .github/workflows",
) )
if diff_only_head.ok and diff_only_head.output: if diff_only_head.ok and diff_only_head.output:

1
tests/test_workflow_push_guard.py
View file

@ -1,7 +1,6 @@
from __future__ import annotations from __future__ import annotations
import json import json
import os
from typing import Any from typing import Any
import pytest import pytest

2
ui/src/routes/login.tsx
View file

@ -63,7 +63,7 @@ function Login() {
</CardHeader> </CardHeader>
<CardContent> <CardContent>
<a <a
href={loginUrl(authRedirectUrl(intendedPath))} href={loginUrl(intendedPath)}
className={cn(buttonVariants({ size: "lg" }), "w-full")} className={cn(buttonVariants({ size: "lg" }), "w-full")}
> >
Continue with GitHub Continue with GitHub