2026-06-15 09:48:12 -07:00
|
|
|
from __future__ import annotations
|
|
|
|
|
|
|
|
|
|
from datetime import UTC, datetime, timedelta
|
2026-06-16 19:38:36 -07:00
|
|
|
from unittest.mock import AsyncMock, patch
|
2026-06-15 09:48:12 -07:00
|
|
|
|
|
|
|
|
import pytest
|
|
|
|
|
|
|
|
|
|
from agent.dashboard import eval_jobs
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_get_status_returns_idle_when_no_record() -> None:
|
|
|
|
|
with patch.object(eval_jobs, "_get_record", new=AsyncMock(return_value=None)):
|
|
|
|
|
status = await eval_jobs.get_reviewer_eval_status()
|
|
|
|
|
assert status["status"] == "idle"
|
|
|
|
|
assert status["name"] == eval_jobs.REVIEWER_EVAL_KEY
|
|
|
|
|
|
|
|
|
|
|
2026-06-16 19:38:36 -07:00
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_get_status_returns_terminal_record_unchanged() -> None:
|
|
|
|
|
record = {"name": "reviewer", "status": "completed", "experiment_url": "https://x"}
|
|
|
|
|
with (
|
|
|
|
|
patch.object(eval_jobs, "_get_record", new=AsyncMock(return_value=record)),
|
|
|
|
|
patch.object(eval_jobs, "_put_record", new=AsyncMock(side_effect=lambda r: r)) as put,
|
|
|
|
|
):
|
|
|
|
|
status = await eval_jobs.get_reviewer_eval_status()
|
|
|
|
|
assert status is record
|
|
|
|
|
put.assert_not_awaited()
|
|
|
|
|
|
|
|
|
|
|
2026-06-15 09:48:12 -07:00
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_get_status_reconciles_stale_running() -> None:
|
|
|
|
|
stale = (datetime.now(UTC) - timedelta(seconds=300)).isoformat()
|
|
|
|
|
record = {"name": "reviewer", "status": "running", "heartbeat": stale}
|
|
|
|
|
with (
|
|
|
|
|
patch.object(eval_jobs, "_get_record", new=AsyncMock(return_value=record)),
|
|
|
|
|
patch.object(eval_jobs, "_put_record", new=AsyncMock(side_effect=lambda r: r)) as put,
|
|
|
|
|
):
|
|
|
|
|
status = await eval_jobs.get_reviewer_eval_status()
|
|
|
|
|
assert status["status"] == "failed"
|
|
|
|
|
assert "no longer tracked" in status["error"]
|
|
|
|
|
put.assert_awaited_once()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
|
|
|
async def test_get_status_keeps_running_with_fresh_heartbeat() -> None:
|
2026-06-16 19:38:36 -07:00
|
|
|
"""A poll must not kill a run whose Action is still heartbeating."""
|
2026-06-15 09:48:12 -07:00
|
|
|
fresh = datetime.now(UTC).isoformat()
|
|
|
|
|
record = {"name": "reviewer", "status": "running", "heartbeat": fresh}
|
|
|
|
|
with (
|
|
|
|
|
patch.object(eval_jobs, "_get_record", new=AsyncMock(return_value=record)),
|
|
|
|
|
patch.object(eval_jobs, "_put_record", new=AsyncMock(side_effect=lambda r: r)) as put,
|
|
|
|
|
):
|
|
|
|
|
status = await eval_jobs.get_reviewer_eval_status()
|
|
|
|
|
assert status["status"] == "running"
|
|
|
|
|
put.assert_not_awaited()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
2026-06-16 19:38:36 -07:00
|
|
|
async def test_get_status_fails_running_without_heartbeat() -> None:
|
|
|
|
|
"""A running record with no heartbeat at all is treated as stale."""
|
|
|
|
|
record = {"name": "reviewer", "status": "running"}
|
2026-06-15 09:48:12 -07:00
|
|
|
with (
|
2026-06-16 19:38:36 -07:00
|
|
|
patch.object(eval_jobs, "_get_record", new=AsyncMock(return_value=record)),
|
2026-06-16 10:12:35 -07:00
|
|
|
patch.object(eval_jobs, "_put_record", new=AsyncMock(side_effect=lambda r: r)),
|
|
|
|
|
):
|
2026-06-16 19:38:36 -07:00
|
|
|
status = await eval_jobs.get_reviewer_eval_status()
|
|
|
|
|
assert status["status"] == "failed"
|