mirror of
https://github.com/Sea-Haven-Industries/meal-order-manager.git
synced 2026-10-01 11:43:12 +00:00
a51251b000
Promote operation-4xx-response and the 2xx-or-3xx success rule to error. Replace unused health and roster 400s with 403, matching portal health. Form-status keeps its real 400 for invalid week. Co-authored-by: Adam Moussa <amoussa1229@users.noreply.github.com>
33 lines
1.4 KiB
Python
33 lines
1.4 KiB
Python
"""OpenAPI 3.1 + Redocly recommended, matching internal-portal (DEV-289)."""
|
|
|
|
from pathlib import Path
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
|
|
|
|
def test_openapi_uses_redocly_recommended():
|
|
redocly = (ROOT / ".redocly.yaml").read_text()
|
|
package = (ROOT / "package.json").read_text()
|
|
spec = (ROOT / "openapi.yaml").read_text()
|
|
ci = (ROOT / ".github" / "workflows" / "ci.yml").read_text()
|
|
assert "extends:" in redocly
|
|
assert "- recommended" in redocly
|
|
assert "operation-2xx-response: off" in redocly
|
|
assert "operation-4xx-response: error" in redocly
|
|
assert "rule/operation-2xx-or-3xx-response" in redocly
|
|
assert "severity: error" in redocly
|
|
health = spec.split("/api/health:", 1)[1].split("\n /", 1)[0]
|
|
assert '"403":' in health
|
|
assert '"400":' not in health
|
|
roster = spec.split("/api/roster:", 1)[1].split("\n /", 1)[0]
|
|
assert '"403":' in roster
|
|
assert '"400":' not in roster
|
|
form_status = spec.split("/api/form-status/{week}:", 1)[1].split("\n /", 1)[0]
|
|
assert '"400":' in form_status
|
|
assert "root: openapi.yaml" in redocly
|
|
assert '"openapi:lint"' in package
|
|
assert '"@redocly/cli": "2.52.1"' in package
|
|
assert "npm run openapi:lint" in ci
|
|
assert "openapi: 3.1.0" in spec
|
|
assert "required: [stage, sha]" in spec
|
|
assert "{ error: string }" in spec or "`{ error: string }`" in spec
|