Commit graph

13 commits

Author SHA1 Message Date
d5a54b2e78
test(form): cover a11y labels, status region, and desc toggle
Structural checks for dual status nodes and no alert(); Playwright for
init-time qty labels, aria-pressed chips, overflow More/Less, and
failed-submit text landing in role=alert.
2026-07-30 20:39:12 -04:00
5ba3f00157
test(form): stub admin lookup in browser tests 2026-07-30 20:29:43 -04:00
91286fc922
fix(form): guard stale admin edit responses 2026-07-30 20:27:19 -04:00
e60b8e26dd fix(form): address review findings 2026-07-30 20:25:37 -04:00
dea398626f test(form): cover sticky footer at narrow widths 2026-07-30 20:25:37 -04:00
0b60d4db55
fix(tests): restore class fixture discovery 2026-07-30 20:22:48 -04:00
Adam Moussa
bb1107ad7f
fix: add @classmethod and use cls in tests/test_generate_form.py
Co-authored-by: seahaven-openswe[bot] <296972425+seahaven-openswe[bot]@users.noreply.github.com>
2026-07-30 20:12:56 -04:00
2df66fd36f
test(form): strengthen phone-width coverage 2026-07-30 19:49:47 -04:00
fca2ec6044
test(form): guarantee Playwright browser cleanup 2026-07-30 19:35:30 -04:00
84cb6251fe
style(tests): apply ruff formatting 2026-07-30 19:28:07 -04:00
58be9ea2f6
fix(form): preserve 480px user bar boundary
Keep the mobile layout below 480px and lock both sides of the breakpoint with browser coverage.
2026-07-30 19:22:59 -04:00
ae03a227d5
fix(form): wrap Google user bar at phone widths
Allow the signed-in Google identity and admin controls to wrap below 480px while preserving the desktop row, with generated-form Playwright coverage for phone widths.
2026-07-30 19:22:28 -04:00
Adam Moussa
216618a862
refactor(form): extract Jinja templates and lock form JS in CI (#77)
Some checks are pending
Deploy / deploy (push) Waiting to run
* refactor(form): extract Jinja templates and lock form JS in CI

Split the monolithic generate_form f-string into form.html.j2/css/js
plus admin.js, inject a single window.CONFIG blob, and add structural
plus Playwright coverage so qty delegation and clamp stay green in CI.

* Update src/server/generate_form.py

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix(form): isolate admin script bindings

* fix(form): address admin and form review findings

* fix(form): resolve remaining review nitpicks

* ci(workflow): restore required check context

Keep the reusable workflow caller job compatible with the organization-required ci / ci status check.

* fix(form): address remaining review findings

* fix: apply CodeRabbit auto-fixes

Fixed 1 file(s) based on 1 unresolved review comment.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
2026-07-30 19:19:51 -04:00