adam/meal-order-manager
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/meal-order-manager.git synced 2026-10-06 19:21:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Slack API calls that require form-urlencoded encoding (#7)
Some checks are pending
Deploy / deploy (push) Waiting to run
Details

Browse source 
conversations.members, conversations.open, and users.info reject
JSON body with 'missing required field'. Use form-urlencoded for
these methods while keeping JSON for chat.postMessage and
files.upload which require it for structured blocks/payloads.
This commit is contained in:
Adam Moussa 2026-05-12 20:05:48 -04:00 • committed by GitHub
parent 135c6be6f7
commit 11ea599bbd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/shared/shared/slack.py
View file

@ -1,7 +1,8 @@
import json import json
import os import os
import urllib.request
import urllib.error import urllib.error
import urllib.parse
import urllib.request
from shared.secrets import get_secret, get_parameter from shared.secrets import get_secret, get_parameter
_token = None _token = None
@ -18,14 +19,19 @@ def _get_channel() -> str:
return get_parameter(os.environ["SLACK_CHANNEL_PARAM"]) return get_parameter(os.environ["SLACK_CHANNEL_PARAM"])
def _api_call(method: str, payload: dict) -> dict: def _api_call(method: str, payload: dict, use_json: bool = True) -> dict:
data = json.dumps(payload).encode() if use_json:
data = json.dumps(payload).encode()
content_type = "application/json; charset=utf-8"
else:
data = urllib.parse.urlencode(payload).encode()
content_type = "application/x-www-form-urlencoded"
req = urllib.request.Request( req = urllib.request.Request(
f"https://slack.com/api/{method}", f"https://slack.com/api/{method}",
data=data, data=data,
headers={ headers={
"Authorization": f"Bearer {_get_token()}", "Authorization": f"Bearer {_get_token()}",
"Content-Type": "application/json", "Content-Type": content_type,
}, },
) )
with urllib.request.urlopen(req) as resp: with urllib.request.urlopen(req) as resp:
@ -40,7 +46,7 @@ def post_channel_message(text: str, blocks: list[dict] | None = None):
def send_dm(user_id: str, text: str, blocks: list[dict] | None = None): def send_dm(user_id: str, text: str, blocks: list[dict] | None = None):
open_resp = _api_call("conversations.open", {"users": user_id}) open_resp = _api_call("conversations.open", {"users": user_id}, use_json=False)
if not open_resp.get("ok"): if not open_resp.get("ok"):
return open_resp return open_resp
channel = open_resp["channel"]["id"] channel = open_resp["channel"]["id"]
@ -69,7 +75,7 @@ def get_channel_members(channel_id: str) -> list[str]:
payload = {"channel": channel_id, "limit": 200} payload = {"channel": channel_id, "limit": 200}
if cursor: if cursor:
payload["cursor"] = cursor payload["cursor"] = cursor
resp = _api_call("conversations.members", payload) resp = _api_call("conversations.members", payload, use_json=False)
if not resp.get("ok"): if not resp.get("ok"):
break break
members.extend(resp.get("members", [])) members.extend(resp.get("members", []))
@ -80,7 +86,7 @@ def get_channel_members(channel_id: str) -> list[str]:
def get_user_info(user_id: str) -> dict | None: def get_user_info(user_id: str) -> dict | None:
resp = _api_call("users.info", {"user": user_id}) resp = _api_call("users.info", {"user": user_id}, use_json=False)
if resp.get("ok"): if resp.get("ok"):
return resp["user"] return resp["user"]
return None return None