adam/meal-order-manager
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/meal-order-manager.git synced 2026-10-06 06:31:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Drop pending-sign-off wording from alarm docs

Browse source 
Duration/Latency thresholds are owner-approved; remove PENDING ADAM
SIGN-OFF / pending-sign-off notes from template.yaml comments and README.
This commit is contained in:
Adam Moussa 2026-06-17 14:35:14 -04:00
parent cefe74ec25
commit 0e3b7a87c9
2 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
README.md
View file

@ -74,13 +74,13 @@ sit in ALARM between runs). Alarm names follow `meal-order-manager-<fn>-<signal>
over 5 min, fires on any error/throttle (threshold 0). over 5 min, fires on any error/throttle (threshold 0).
- **Lambda Duration** — p99 over 5 min at ~80% of each function's timeout. - **Lambda Duration** — p99 over 5 min at ~80% of each function's timeout.
API-fronted functions (submit-order, admin-authorizer) evaluate 3/3 datapoints; API-fronted functions (submit-order, admin-authorizer) evaluate 3/3 datapoints;
cron/async functions evaluate a single datapoint. Thresholds pending sign-off. cron/async functions evaluate a single datapoint.
- **DynamoDB orders table** — `ReadThrottleEvents` and `WriteThrottleEvents` - **DynamoDB orders table** — `ReadThrottleEvents` and `WriteThrottleEvents`
(TableName dimension). DynamoDB does not publish `ThrottledRequests`/`SystemErrors` (TableName dimension). DynamoDB does not publish `ThrottledRequests`/`SystemErrors`
at the table-only dimension, so those are intentionally not alarmed. at the table-only dimension, so those are intentionally not alarmed.
- **API Gateway (OrderApi, HTTP API v2)** — 5xx (threshold 0), 4xx (threshold 20, - **API Gateway (OrderApi, HTTP API v2)** — 5xx (threshold 0), 4xx (threshold 20,
3/2 datapoints to absorb routine 401s from the token authorizer), and p99 Latency 3/2 datapoints to absorb routine 401s from the token authorizer), and p99 Latency
(~3000ms, pending sign-off). (~3000ms).
## Authentication ## Authentication

7
template.yaml
View file

@ -608,8 +608,7 @@ Resources:
# Duration alarms use ExtendedStatistic p99 at ~80% of each function's # Duration alarms use ExtendedStatistic p99 at ~80% of each function's
# configured timeout. Synchronous (API-fronted) functions evaluate over # configured timeout. Synchronous (API-fronted) functions evaluate over
# 3 datapoints; cron / async-invoked functions evaluate a single datapoint # 3 datapoints; cron / async-invoked functions evaluate a single datapoint
# (they fire too rarely for a multi-datapoint window). These thresholds # (they fire too rarely for a multi-datapoint window).
# are pending Adam sign-off — see PR body.
# Lambda Errors (Sum, 5min, any error breaches) # Lambda Errors (Sum, 5min, any error breaches)
SubmitOrderErrorsAlarm: SubmitOrderErrorsAlarm:
@ -879,7 +878,7 @@ Resources:
AlarmActions: AlarmActions:
- arn:aws:sns:us-east-1:328440206208:site-alerts - arn:aws:sns:us-east-1:328440206208:site-alerts
# Lambda Duration p99 (~80% of timeout) — PENDING ADAM SIGN-OFF # Lambda Duration p99 (~80% of timeout)
# Synchronous (API-fronted) functions: eval 3 / datapoints 3. # Synchronous (API-fronted) functions: eval 3 / datapoints 3.
SubmitOrderDurationAlarm: SubmitOrderDurationAlarm:
Type: AWS::CloudWatch::Alarm Type: AWS::CloudWatch::Alarm
@ -1111,7 +1110,7 @@ Resources:
AlarmActions: AlarmActions:
- arn:aws:sns:us-east-1:328440206208:site-alerts - arn:aws:sns:us-east-1:328440206208:site-alerts
# Latency p99 ~3000ms — PENDING ADAM SIGN-OFF (see PR body). # Latency p99 ~3000ms (see PR body).
OrderApiLatencyAlarm: OrderApiLatencyAlarm:
Type: AWS::CloudWatch::Alarm Type: AWS::CloudWatch::Alarm
Properties: Properties: