From c771ed4f0868a9a56d5b287cb0a986bc365e112d Mon Sep 17 00:00:00 2001
From: Adam Moussa <166072409+amoussa1229@users.noreply.github.com>
Date: Thu, 14 May 2026 11:38:31 -0400
Subject: [PATCH] Rename SECRET_ARN env vars to SECRET_NAME to match actual
 values

---
 lambda/backup-verification/app.py     | 8 ++++----
 lib/constructs/backup-verification.ts | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/lambda/backup-verification/app.py b/lambda/backup-verification/app.py
index 77c886d..7b2aae9 100644
--- a/lambda/backup-verification/app.py
+++ b/lambda/backup-verification/app.py
@@ -18,8 +18,8 @@ secrets = boto3.client("secretsmanager")
 SOURCE_BUCKET = os.environ["SOURCE_BUCKET"]
 REPLICA_BUCKET = os.environ["REPLICA_BUCKET"]
 GCS_BUCKET = os.environ["GCS_BUCKET"]
-GCS_SA_SECRET_ARN = os.environ["GCS_SA_SECRET_ARN"]
-SLACK_WEBHOOK_SECRET_ARN = os.environ["SLACK_WEBHOOK_SECRET_ARN"]
+GCS_SA_SECRET_NAME = os.environ["GCS_SA_SECRET_NAME"]
+SLACK_WEBHOOK_SECRET_NAME = os.environ["SLACK_WEBHOOK_SECRET_NAME"]
 
 _gcs_client = None
 
@@ -27,7 +27,7 @@ _gcs_client = None
 def _get_gcs_client():
     global _gcs_client
     if _gcs_client is None:
-        raw = secrets.get_secret_value(SecretId=GCS_SA_SECRET_ARN)["SecretString"]
+        raw = secrets.get_secret_value(SecretId=GCS_SA_SECRET_NAME)["SecretString"]
         info = json.loads(raw)
         creds = service_account.Credentials.from_service_account_info(info)
         _gcs_client = gcs.Client(credentials=creds, project=info.get("project_id"))
@@ -167,7 +167,7 @@ def _restore_test():
 
 
 def _post_slack(blocks):
-    raw = secrets.get_secret_value(SecretId=SLACK_WEBHOOK_SECRET_ARN)["SecretString"]
+    raw = secrets.get_secret_value(SecretId=SLACK_WEBHOOK_SECRET_NAME)["SecretString"]
     webhook_url = raw.strip()
     payload = json.dumps({"blocks": blocks}).encode()
     req = urllib.request.Request(
diff --git a/lib/constructs/backup-verification.ts b/lib/constructs/backup-verification.ts
index c7607da..8200951 100644
--- a/lib/constructs/backup-verification.ts
+++ b/lib/constructs/backup-verification.ts
@@ -33,8 +33,8 @@ export class BackupVerification extends Construct {
         SOURCE_BUCKET: props.sourceBucket.bucketName,
         REPLICA_BUCKET: props.replicaBucketName,
         GCS_BUCKET: props.gcsBucket,
-        GCS_SA_SECRET_ARN: props.gcsSaSecretName,
-        SLACK_WEBHOOK_SECRET_ARN: props.slackWebhookSecretName,
+        GCS_SA_SECRET_NAME: props.gcsSaSecretName,
+        SLACK_WEBHOOK_SECRET_NAME: props.slackWebhookSecretName,
       },
       logRetention: logs.RetentionDays.TWO_MONTHS,
     });