From 45a63e8552eca2099e13fd25b178c65a07d584e2 Mon Sep 17 00:00:00 2001
From: Adam Moussa <166072409+amoussa1229@users.noreply.github.com>
Date: Fri, 15 May 2026 18:08:14 -0400
Subject: [PATCH] Restore overrideLogicalId on GcsTransferCredentials secret

Removing this changed the CloudFormation logical ID from
GcsTransferCredentials to GcsTransferCredentials35DA7E5D,
triggering a replacement that fails because the named secret
already exists.
---
 lib/forgejo-stack.ts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/forgejo-stack.ts b/lib/forgejo-stack.ts
index c4c20d3..fa0c185 100644
--- a/lib/forgejo-stack.ts
+++ b/lib/forgejo-stack.ts
@@ -167,6 +167,10 @@ export class ForgejoStack extends cdk.Stack {
         secretAccessKey: gcsTransferKey.secretAccessKey,
       },
     });
+    // Preserve the logical ID to avoid CloudFormation replacement
+    const gcsTransferCredentialsResource = gcsTransferCredentials.node.defaultChild as secretsmanager.CfnSecret;
+    gcsTransferCredentialsResource.overrideLogicalId("GcsTransferCredentials");
+
     const userData = ec2.UserData.forLinux();
     userData.addCommands(
       "set -euxo pipefail",