adam/exec-aide
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ci: fail ci/ci aggregator on skipped needed jobs (INFRA-136) (#74)

Browse source 
The inline ci/ci aggregator green-lit the org-required check when a
needed job was SKIPPED (result 'skipped' is neither 'failure' nor
'cancelled'). Treat 'skipped' as a failure so a conditionally-skipped
required job can no longer pass the required check without running.

Contained inline fix; the audit's shared callable-ci-aggregate.yaml
(Stub 4) is deferred as it needs a new org-wide reusable workflow.
This commit is contained in:
Adam Moussa 2026-07-08 16:53:52 -04:00 • committed by GitHub
parent f5196248c2
commit d10480b005
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/ci.yaml vendored
View file

@ -24,4 +24,6 @@ jobs:
steps: steps:
- name: All CI jobs passed - name: All CI jobs passed
run: | run: |
[ "${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}" = "false" ] # A skipped needed job must NOT green-light the required "ci / ci"
# context, so treat 'skipped' as a failure alongside failure/cancelled.
[ "${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') || contains(needs.*.result, 'skipped') }}" = "false" ]