mirror of
https://github.com/Sea-Haven-Industries/engineering-handbook.git
synced 2026-09-30 03:23:14 +00:00
Engineering conventions and best practices for Sea Haven Industries
Adam Moussa
cfb50ff1fc
Pipeline deploy on merge to main (or workflow_dispatch where a repo configures one) is now the only sanctioned path. Local deploy-then-merge drops to a documented legacy exception that requires a data-loss-prone stateful change plus advance sign-off, recorded in the PR notes. Also correct the hook install path for the repo's move under repositories/seahaven/, and document that core.hooksPath is a single directory rather than a search path, so a repo-local setting silently shadows the machine-global security pre-push unless the repo hook is a shim that re-execs it. |
||
|---|---|---|
| .github | ||
| constructs | ||
| hooks | ||
| scripts | ||
| .markdownlint-cli2.jsonc | ||
| aws-infrastructure.md | ||
| bedrock.md | ||
| cdk-project-layout.md | ||
| cicd.md | ||
| code-review-rubric.md | ||
| code-review.md | ||
| commit-messages.md | ||
| CONTRIBUTING.md | ||
| dev-environment.md | ||
| git-workflow.md | ||
| github-standards.md | ||
| lambda-template.md | ||
| LICENSE | ||
| lychee.toml | ||
| naming-conventions.md | ||
| pull-requests.md | ||
| README.md | ||
| sam-project-layout.md | ||
| secrets-and-config.md | ||
Engineering Handbook
Engineering conventions and best practices for Sea Haven Industries.
Contents
- Naming Conventions -- kebab-case everywhere, no exceptions
- Development Environment -- workstation directory layout, pyenv, Node, launchd/TCC
- Git Workflow -- feature branches, incremental commits, deploy-then-merge
- Commit Messages -- Conventional Commits, type(scope) format, explain "why"
- Pull Requests -- scope, title, description format, merge strategy
- Code Review -- what to look for, giving feedback, turnaround expectations
- Code Review Rubric -- BLOCK/FIX/NIT/QUESTION finding categories and output format
- GitHub Standards -- branch defaults, repo hygiene, Dependabot
- AWS Infrastructure -- SAM vs CDK, Lambda defaults, CloudFormation
- SAM Project Layout -- standard directory structure for serverless projects
- CDK Project Layout -- standard directory structure for CDK projects
- Lambda Starter Template -- minimal SAM scaffold for a new Python Lambda
- Secrets and Configuration -- Secrets Manager vs SSM Parameter Store
- CI/CD Pipelines -- every deployable repo gets a pipeline, no manual deploys
- Bedrock -- cross-region inference profiles, alias pinning, KB Docker requirement
- Git Hooks -- recommended pre-push and pre-commit hooks
- Scripts -- repo provisioning, automation tooling
- CDK Constructs -- shared VPN EC2 instance construct and other reusable patterns
Contributing
See CONTRIBUTING.md.
License
This work is licensed under CC-BY-4.0. The commit messages section adapts content from commit-messages-guide by Romulo Oliveira, also licensed under CC-BY-4.0.