adam/engineering-handbook
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/engineering-handbook.git synced 2026-09-30 03:23:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

docs(review): retire security and cross-family review gates (#49)
Some checks failed
ci / ci / ci (push) Has been cancelled
Details

Browse source 
Security review and cross-family review are no longer merge gates. Deploy docs still require a job_workflow_ref update when a workflow is added.
This commit is contained in:
Adam Moussa 2026-09-26 17:19:45 -04:00 • committed by GitHub
parent b651a74c7e
commit fa1aed0abc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cicd.md
View file

@ -142,7 +142,7 @@ IAM role `githubdeploy-<repo>`, owned by workload Terraform.
- `job_workflow_ref`: `Sea-Haven-Industries/.github/.github/workflows/cd-hcp-fargate.yaml@*` (and `cd-hcp-spa.yaml`)
- `workflow_ref`: the thin caller still `Sea-Haven-Industries/<repo>/.github/workflows/deploy-api.yaml@refs/heads/main` and `@refs/tags/v*`
Adding an app adds `workflow_ref` for that caller. Do not pin trust to only `ref:refs/heads/main`.
Adding an app still adds `workflow_ref` for that caller. Do not pin trust to only `ref:refs/heads/main`.
**Permissions.** Only what the workflows write: