adam/afterhours-shift-manager
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/afterhours-shift-manager.git synced 2026-10-05 02:32:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Stop logging extension numbers in 3CX queue updates

Browse source 
Resolves 3 high CodeQL py/clear-text-logging-sensitive-data alerts: the
queue/ring-group forwarding logs no longer include the routed extension
values (closed/holiday/extension). Non-sensitive context (resource id,
queue number) is retained.
This commit is contained in:
Adam Moussa 2026-06-01 19:05:01 -04:00
parent 21dd11ada6
commit 42edf62952
2 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/shared/shared/ring_scheduler.py
View file

@ -27,5 +27,5 @@ def update_queue_routing(
closed=extension, closed=extension,
holiday=extension, holiday=extension,
) )
logger.info("Updated queue %s to forward to Ext %s", queue_number, extension) logger.info("Updated queue %s forwarding", queue_number)
return {"extension": extension, "queue": queue_number} return {"extension": extension, "queue": queue_number}

8
src/shared/shared/three_cx_client.py
View file

@ -102,13 +102,7 @@ class ThreeCXClient:
json=payload, json=payload,
) )
resp.raise_for_status() resp.raise_for_status()
logger.info( logger.info("Updated %s %s forwarding", resource, resource_id)
"Updated %s %s: closed->Ext %s, holiday->Ext %s",
resource,
resource_id,
closed,
holiday,
)
return resp.status_code return resp.status_code
def get_ring_group(self, extension_number: str) -> dict: def get_ring_group(self, extension_number: str) -> dict: